[MPlayer-dev-eng] [PATCH] Maybe fix gcc4 for problems on amd64 without breaking other arches

[cartman]

On Tue, Jul 12, 2005 at 10:51:27AM +0200, Guillaume POIRIER wrote:
> Hej,
> 
> On 7/7/05, Ismail Donmez <ismail at kde.org.tr> wrote:
> > On Thursday 07 July 2005 18:28, Guillaume POIRIER wrote:
> > > (now I'm off to leach some cola) :)
> > 
> > Bring me some too, its too hot here! :)
> 
> :-)
> 
> Here's what I think is a better patch that conditionally compiles
> either version of the problematic line depending on the GCC version.
> 

This is very ugly but I don't see another solution unless someone with more
asm knowledge provides a better patch.
 
> --- MPlayer-20050707/postproc/swscale_template.c	2005-06-30 07:35:26.000000000 +0200
> +++ MPlayer-20050707-patched/postproc/swscale_template.c	2005-07-07 17:03:53.364963179 +0200
> @@ -2546,8 +2546,11 @@
>  		"add $1, %%"REG_a"		\n\t"
>  		"cmp %2, %%"REG_a"		\n\t"
>  		" jb 1b				\n\t"
> -
> +#ifdef (__GNUC__ > 4)	// GCC-3.3 makes MPlayer crash on IA-32 machines when using "g" operand here, which is needed to support GCC-4.0
> +		:: "m" (src1), "m" (dst), "g" ((long)dstWidth), "m" (xInc_shr16), "m" (xInc_mask),

Maybe you should use C style /* comments */ here *g*


ismail

-- 
Animals use pee to mark their territories. Humans use others' girl friends
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20050712/84bb62d8/attachment.pgp>