[MPlayer-dev-eng] [PATCH] CQMs in x264

[Alexander Strasser]

Hi,

Robert Swain wrote:
> On 7/12/05, Guillaume POIRIER <poirierg at gmail.com> wrote:
> > On 7/12/05, Robert Swain <robert.swain at gmail.com> wrote:
> > > The problem is Windows paths are given as "C:\path\to\mymatrix.cfg".
> > > As this path contains ':' it causes problems because it thinks
> > > "\path\to\mymatrix.cfg" is the next x264 option.
> > 
> > Ok. I think there are two solutions available. One is using double or
> > single quotes when the path is in windows format. Untested, but that
> > might work.
> > 
> > The other solution is to make use of the recent code Reimar committed
> > to the subopt parser.
> > 
> > Here is what the doc says:
> > 
> > NOTE: The suboption parser (used for example for -ao pcm suboptions)
> > supports a special kind of string-escaping in- tended for use with
> > external GUIs.
> > It has the following format:
> > %n%string_of_length_n
> > EXAMPLE:
> > mplayer -ao pcm:file=%10%C:test.wav test.avi
> 
> I tried single and double quotes and they don't fix the problem. Does
> the code by Reimar apply to all suboptions? I think it would be
> reasonable. I tried it for -x264encopts but it didn't work so I'm
> guessing it only applies to some suboptions. I'll have a look and see
> what I can grep in the source.

  the double quotes of course don't work, because this string is not
parsed by the shell but by mplayer, the shell already removes the double
quotes when parsing the whole command line so the double quotes never
ever reach mplayer.

  The code reimar wrote doesn't apply to all suboptions, it only works
with the suboption parser i wrote as a drop in replacement for the chaos
that was going on in the various vo/ao drivers. Maybe it is time to
merge my and reimars code with the cmdline/config parser. But this will
need further investigation.

  Anyway for now you can imho just ignore the `:' issue with windows path.
A workaround for windows users to use full path specification would be
to use unix environments for windows that eliminate the need for `:' such
as cygwin and mingw/msys.

  Alex (beastd)