[MPlayer-dev-eng] [PATCH] x264 fast first pass

[Guillaume POIRIER]

Hi,

On 7/10/05, Jeff Clagg <snacky at ikaruga.co.uk> wrote:
> On Sat, Jul 09, 2005 at 06:53:13PM +0100, Robert Swain wrote:
> > Hello all,
> >
> > After a request was made I have written a small patch that adds a fast
> > first pass feature to x264 in mencoder. The VFW version of x264 has been
> > using a conservative fast first pass for a long while and I have tested a
> > second set of reduced complexity settings myself which seem to give good
> > results. As such specifying fastfirstpass=<0-2> in the x264encopts allows
> > for the following settings:
> 
> First, I think that for consistency with the options in mplayer's other
> encoding libs (lavc, xvid), it would be a good idea to name the option
> "turbo" instead of "fastfirstpass."
> 
> > 0 - disabled (same as omission)
> 
> Since this is the default, and since firstpass=0 has absolutely no
> effect, I suggest not documenting it at all, and only telling users
> about firstpass=[12].

I do not agree. I do believe that we'd better over-document than
remove some informations that users may ask on the ML.

The valid range should be: 
.B fastfirstpass=<0\-2>

and how about :
0 - disabled (default)

[..]

Guillaume
-- 
Hollywood is a place where they'll pay you a thousand dollars for a
kiss and fifty cents for your soul.
 -- Marilyn Monroe