[MPlayer-dev-eng] [PATCH] x264 fast first pass

[Jeff Clagg]

On Sat, Jul 09, 2005 at 06:53:13PM +0100, Robert Swain wrote:
> Hello all,
> 
> After a request was made I have written a small patch that adds a fast 
> first pass feature to x264 in mencoder. The VFW version of x264 has been 
> using a conservative fast first pass for a long while and I have tested a 
> second set of reduced complexity settings myself which seem to give good 
> results. As such specifying fastfirstpass=<0-2> in the x264encopts allows 
> for the following settings:

First, I think that for consistency with the options in mplayer's other
encoding libs (lavc, xvid), it would be a good idea to name the option
"turbo" instead of "fastfirstpass."

> 0 - disabled (same as omission)

Since this is the default, and since firstpass=0 has absolutely no
effect, I suggest not documenting it at all, and only telling users
about firstpass=[12].

> 1 - reduced settings in the same fashion as the VFW fast first pass (number 
> of references, subq and reduction of subpartition types; cf the patch or 
> x264 source for further details)
> 2 - reduced settings ( frame_ref = 1, subq = 1, no sub-partitions, no 
> 8x8dct, and diamond ME search)
> 
> I also tried to update the documentation but I'm unfamiliar with the 
> notation used for the man pages.

Try "man ./mplayer.1" to test the rendering of your local copy. Your
patch messes up indentation (more on this below).

> +reduce subq, frame_ref and disable some inter macroblock partition analysis
> +modes

Change "frame_ref" to "frameref"

> +reduce subq and frame_ref to 1, use a diamond ME search, disable all
> +sub-partition analysis modes and don't use the 8x8 DCT

Again, frame_ref => frameref. And isn't 8x8dct a sub-partition type? So
no need to mention it specially. (also, contractions like "don't" are
considered to be against the mplayer man page style rules iirc)

Finally, add a line like ".PD 1" at the bottom of your manpage changes;
the way you have it now, all indentation below your new option is broken.