[MPlayer-dev-eng] [PATCH] clean up tests in configure

[Reimar Döffinger]

Hi,
On Wed, Jul 06, 2005 at 11:10:19PM +0300, Ivan Kalvachev wrote:
> I cannot believe that an C programmer would prefer -o/-r over ||/&&.
> If you really do ,I do recomend putting:
> #define -o ||
> #define -r &&
> and repleacing all occurances of &&/||. (e.g
> if((stream_dump_type)-a(stream_dump_type<4)) ;)

This was not in general, this is a script, and most comparisons are of a
different type (and less complicated) than in C. Also, writing || or &&
in this case also includes writing "test" again.

> Also If you find {} unreadable then i propose
> #define begin {
> #define end }

No, my point was against replacing () by {}. In C you have usually a lot
more () than {}, and usually {} aren't too essential to understanding
the code, you can just read over them (you usually have an indentation
change at that point as well).
Please don't compare the configure script to a C program! It _is_
something very different.
But hey, maybe we should reimplement configure as a C program *g*

Greetings,
Reimar Döffinger