[MPlayer-dev-eng] [PATCH] clean up tests in configure

Ivan Kalvachev ikalvachev at gmail.com
Wed Jul 6 22:10:19 CEST 2005


On 7/6/05, Alexander Strasser <eclipse7 at gmx.net> wrote:
> Ivo wrote:
> > On Wednesday 06 July 2005 01:19, Diego Biurrun wrote:
> > > (and yes, I'm all for [ instead of test).
> >
> > Funny, reading configure, I was always under the impression test was used
> > instead of [ for portability issues or something like that. But it wasn't?
> > What was the reason configure is full of test instead of [ ?
> 
>   I heard about test being more portable. But you never know.
> And maybe configure even breaks on some seldom platforms and
> just nobody noticed it. Anyway we can always wait for bug
> reports and take global action (on configure not mother earth).

Well, well, well.
OK. If this link is correct 
http://www.opengroup.org/onlinepubs/009695399/utilities/xcu_chap02.html
then `test` is not standard extension for /bin/sh . I guess it is
bash-ism and this is the reason it is implemented also as external
program.
Don't forget that configure starts with /bin/sh . 

[flame][ignore]
I cannot believe that an C programmer would prefer -o/-r over ||/&&.
If you really do ,I do recomend putting:
#define -o ||
#define -r &&
and repleacing all occurances of &&/||. (e.g
if((stream_dump_type)-a(stream_dump_type<4)) ;)
Also If you find {} unreadable then i propose
#define begin {
#define end }
These combined with our patented random indentation system will
gurantee us an persistent leading place in all C obfiscation
competitions.
[/ignore][/flame]




More information about the MPlayer-dev-eng mailing list