[MPlayer-dev-eng] [PATCH] clean up tests in configure

[Rich Felker]

On Tue, Jul 05, 2005 at 02:42:15AM +0200, Diego Biurrun wrote:
> -a/-o vs &&/||:
> ===============
> 
> You say that
> 
> 1) -a/-o is less readable (even "obfuscated"),
> 2) the possibility for ambiguity with -a/-o is reason enough to reject
>    the patch.
> 
> I disagree on both counts since
> 
> 1a) -a/-o is shorter (and IMO this aids readability on long lines),

then use [ instead of test.

> 1b) -a/-o avoids another test invocation and should thus be faster,

there are no such things as invocations. we're talking
shell-internals.

> 1c) after a short time of getting used to it -a/-o should be equally
>     readable for everyone.

no, it's ugly and ambiguous

> 2) I don't think we run the risk of ever hitting that ambiguity and
>    1a-c) might be a real gain in practise.

essentially zero gain. 90% or more of configure time is spent in gcc
anyway, except on broken archs like windows where fork takes forever.

rich