[MPlayer-dev-eng] [PATCH] clean up tests in configure

Ivan Kalvachev ikalvachev at gmail.com
Tue Jul 5 01:20:06 CEST 2005


On 7/5/05, Alexander Strasser <eclipse7 at gmx.net> wrote:
> Hi,
> 
> Reimar Döffinger wrote:
> > On Mon, Jul 04, 2005 at 10:30:42PM +0300, Ivan Kalvachev wrote:
> > > And I will revert it.
> > > This patch doesn't do anything else than obfiscation.
> >
> > I disagree. The -a/-o syntax is already used in some places, so it would
> > at least create consistency. I also don't think that it is more
> > obfuscated anyway...
> 
>   I am for not changing them to -a and -o. I am not sure it will
> bring any significant speed up that is worth it.
>   If someone proves me wrong, we should at least make special rules
> for using -a and -o so that it is more readable.
> 
>   Removing unneeded subshells should be ok tho...
> 
>   Alex (beastd)
> 

Indeed.
As I said I am for removing () and replacing them with {} that doesn't
invoke subshell and are more readable.
I am also agains -a/-o that are compleatly obfiscated. I would be
happy they to be removed from current configure.

I want this disctution to be guided by what is best designe and not by
comparing musciles ("I'll do it anyway").

I'll do the patch if there are no other volunteers.

Ivan Kalvachev
 iive




More information about the MPlayer-dev-eng mailing list