[MPlayer-dev-eng] [PATCH] dsize negative scale values

Oded Shimon ods15 at ods15.dyndns.org
Mon Jul 4 09:12:58 CEST 2005


On Sun, Jul 03, 2005 at 11:41:45PM -0700, RC wrote:
> On Mon, 4 Jul 2005 06:43:38 +0300
> Oded Shimon <ods15 at ods15.dyndns.org> wrote:
> 
> 
> > resolution... I changed the params from what i said in this thread, i
> > gave imo a very good explanation of the params in the other thread,
> > when i sent the patch:
> 
> The changing parameters explains most of my problems...
> 
> > I really don't want to flame, but seriously, this patch is not that 
> > advanced...
> 
> I'm apparently not the only one who thinks it is rather complex.
> 
> > TBH, I see no reason you would ever want to use the original aspect
> > and not the prescaled one, but i offered the option anyway - if it
> > would really make it that much simpler, do you suggest I remove it?...
> 
> I can see a reason...  In fact, that IS the reason I made the dsize
> patch.  
> 
> 
> How about a compromise between these two?  Why not just add two
> (optional) parameters to my version of the dsize patch...  A max width/
> height value, so eg. "dsize=800:-2:800:600" (or
> dsize=800:-2::600, or dsize=-2:600:800) would work for you, and still be
> very simple and easy for everyone to understand?

TBH that sounds even MORE complicated, I've got a different compromise - 
combine both. It will accept the -2/-3 stuff, AND my 'keepaspect' param if 
it exists. What do you think?..

(dsize=800:-2 and dsize=800:0:1 will both be legal...)

- ods15




More information about the MPlayer-dev-eng mailing list