[MPlayer-dev-eng] [PATCH] libmpdvdkit2 minor cleanups

[Aurelien Jacobs]

On Fri, 1 Jul 2005 00:46:04 +0200
Emanuele Giaquinta <emanuele.giaquinta at gmail.com> wrote:

> Hi,
> 
> the attached patch provides the following cleanups:
> 
> removes unneeded castings on strdup calls.
> adds the 'const' qualificator to the argument of dvdcss_open, to be
> consistent  with the 'DVDcss_open' type.
> Two other fixes to avoid gcc4 warnings with sprintf calls; the
> psz_debug array  can be safely defined signed, instead use a cast for
> psz_serial.

Nice, but if there is no fix (only cleanups), IMHO this patch should be
sent directly upstream, and if it's accepted, it will then be rolled
back in libmpdvdkit2 at next libdvdread/libdvdcss update.

Aurel