[MPlayer-dev-eng] [PATCH] OpenBSD MTRR support

[Ian Lindsay]

On Fri, Jan 21, 2005 at 11:19:12PM -0500, D Richard Felker III wrote:
> On Fri, Jan 21, 2005 at 10:13:27PM -0500, Ian Lindsay wrote:
> > On Fri, Jan 21, 2005 at 10:40:26PM +0100, Alex Beregszaszi wrote:
> > > it's obviously not, any better ideas? at least prefix that mem_fd with
> > > dha_ or something, less pollution on common names
> > 
> > here's the patch with dha_ prefix for a different flavour of namespace
> > pollution. the issue is that you can't open /dev/xf86 multiple times
> > or continue to use mmap'ed region after closing it.
> 
> this makes openbsd very broken and insecure. keeping fd open after
> mmap is a very bad practice from a security standpoint. i don't think
> we should include ugly hacks like this to support a broken os...
> aren't there other ways of making it work anyway? if nothing else,
> make a module like dhahelper/svgalib_helper for openbsd...

i'm not sure what the security implications of having an open fd here are,
but the current code on systems using /dev/mem has lots of open descriptors
while on openbsd we only have one :-)