[MPlayer-dev-eng] [PATCH] VobSub features I.

[Csillag Kristof]

Hi there!

I cleaned up/updated/arranged the first group of mt vobsub patches.

Here we go:

1. 1_mkv_missing_palette_bugfix.patch

This patch fixes the bug with palette-less VobSub streams in MKV
container.

2. 2_calculate_alpha_efficiently.patch

This patch replaces all conditional conversion between alpha and opacity
(0 -> 0; [1..255] -> [255..1]) to the more efficient -c version.
(Discussed and agreed on this list last week.)

3. 3_crop_horizontally_too.patch

This patch is new. 

The story: mplayer was already smart enough to notice when the SPU
picture is needlessly big (there are empty parts on bottom and the top,
apart from the actual subtitle). When this happens, only the relevant
lines  considered. This patch enhances the auto-detection & cropping to
do basically the same thing horizontally, too. (So the empty part on the
left and on the right is discarded, too.)

Why do we want this? Three reasons:
	- To gain some extra speed 
		(why should we overlay an empty picture...)
	- To make the configurable background boxen around the subtitles
		(see the next patch) look good.
	- To make VobSub scaling feasable.

Applying this patch alone will not cause any visible differences,
but it is required for both the configurable background thing,
both the vobsub scaling thing.

4. 4_black_box_bg.patch		

This patch depends on the previous (3_crop_horizontally_too.patch)
patch.

I have already submitted a previous version of this as "configurable
background for vobusub subtitles". Use this to draw a nice gray box
around the subtitles. My suggestion: -spu-bg-alpha 96 -spu-bg-color 16

  * * *

You can test all these features on 

http://rht.bme.hu/~lunkwill/computer/mplayer/clip-2.mkv

What do you think?

   * * *

More to come:

 - VobSub scaling is almost ready, but I want to clean up the 
	positioning code before submitting it. (Right now
	it's very-very redundant and shaggy.)

 - I know that there is a bug which allows positioning the vobsub
	outside the screen, which can make mplayer segfault.
	( try with -spualign 1 -subpos 1, and wait for a subtitle)
	The real solution will be the clean-up of the positioning code.
	Until then, here is the quick fix:
	(csk-vobsub-positioning-bugfix.patch)

That's all for now.
What do you think?


Csillag Kristof <fenwick at freemail.hu>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 1_mkv_missing_palette_bugfix.patch
Type: text/x-patch
Size: 1934 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20050120/840b65e7/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 2_calculate_alpha_efficiently.patch
Type: text/x-patch
Size: 999 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20050120/840b65e7/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 3_crop_horizontally_too.patch
Type: text/x-patch
Size: 4408 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20050120/840b65e7/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 4_black_box_bg.patch
Type: text/x-patch
Size: 3592 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20050120/840b65e7/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: csk-vobsub-positioning-segfault-bugfix.patch
Type: text/x-patch
Size: 2458 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20050120/840b65e7/attachment-0004.bin>