[MPlayer-dev-eng] Patch: Segfault With Subtitles + Missing Codec

Ismail Donmez ismail at kde.org.tr
Fri Jan 14 23:50:45 CET 2005


On Saturday 15 January 2005 00:41, Philip Chong wrote:
> Hi:
>
> I found that playing back a video with a .SSA subtitle file causes a
> segfault if the required video codec is missing, due to a null pointer
> dereference in mplayer.c.  A patch is attached.

Ok your patch is wrong. Surely you mean :

-  if(subdata && sh_video->pts>0)
+  if(subdata && sh_video && sh_video->pts>0){


Cheers,
ismail




More information about the MPlayer-dev-eng mailing list