[MPlayer-dev-eng] [PATCH] bugfix for black bar besides gaussed vobsubs

Reimar Döffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Sat Jan 8 20:05:02 CET 2005


Hi,
On Sat, Jan 08, 2005 at 01:25:31PM -0500, D Richard Felker III wrote:
> On Sat, Jan 08, 2005 at 06:24:20PM +0100, Reimar Döffinger wrote:
> > On Sat, Jan 08, 2005 at 12:08:37PM -0500, D Richard Felker III wrote:
> > > On Sat, Jan 08, 2005 at 03:33:37PM +0100, Reimar Döffinger wrote:
> > > > On Sat, Jan 08, 2005 at 02:52:05PM +0100, Csillag Kristof wrote:
[...]
> > > > > 3. Reverts the alpha values to the "normal" way:
> > > > > 	- 0 still means totally transparent
> > > > > 	- 1 is not transparent at all
> > > > > 	- 255 is almost totally transparent
> > > > > 
> > > > > 	(May I ask, why do we use this interpretation? It's a pain...)
> > > > 
> > > > Agree, I dislike it and it should be changed. I think it's because it
> > > > was like that in the first OSD implementation (and is used when you
> > > > define FAST_OSD). Not 100% sure though.
> > > 
> > > Definitely should not be changed. It's written this way for a reason,
> > > to optimize the alpha blender, which is called on every frame. OSD is
> > > already slow enough..
> > 
> > I think it is only used for a comparison... If a comparison against 255
> > is so much slower than against 0... But I don't know the details..
> 
> It's larger. And this can mean slower if cache is an issue.

Well, then how about: 0 completely transparent, 255 (instead of 1) opaque? And everything inbetween linear?

Greetings,
Reimar Döffinger




More information about the MPlayer-dev-eng mailing list