[MPlayer-dev-eng] patch: can't display mp3

Moritz Bunkus moritz at bunkus.org
Thu Jan 6 22:40:14 CET 2005


Hey,

> That extra from variable is not needed and that cast is complete
> nonsense. Also str should be const (and actually from should be replaced
> by str).

Nope, there are iconv implementations whose char * parameter is NOT
const.

Mosu

-- 
If Darl McBride was in charge, he'd probably make marriage
unconstitutional too, since clearly it de-emphasizes the commercial
nature of normal human interaction, and probably is a major impediment
to the commercial growth of prostitution. - Linus Torvalds




More information about the MPlayer-dev-eng mailing list