[MPlayer-dev-eng] [PATCH] Making all vo globals local

Ivo ivop at euronet.nl
Mon Feb 28 05:55:41 CET 2005


Hi,

Before I commit this, I want your opinion on it. My goal is that no vo 
driver has any global variables. There's no need for that. So, like all 
vf's, vo's should have their own priv struct. In this patch, the priv 
struct pointer is still a global (albeit only to vo_pnm.c itself), but 
eventually the pointer should reside in video_out, be called something like 
vo_priv, and be passed to every vo function it calls.

If you have any comments on this, please respond! If not, I'll start working 
on a huge patch that converts all vo's and video_out.c to this format :-)

Hmm, I just recall that not all vo's use subopt-helper yet, so that has to 
be done first. But after that, would this patch be ok?

--Ivo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cvsdiff-u.nomorevoglobals
Type: text/x-diff
Size: 11407 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20050228/43568ac7/attachment.diff>


More information about the MPlayer-dev-eng mailing list