[MPlayer-dev-eng] [PATCH] -slave-idle option

[D Richard Felker III]

On Sun, Feb 27, 2005 at 01:30:44PM +0100, Diego Biurrun wrote:
> Alexander Strasser writes:
> > Oded Shimon wrote ( On Sun, Feb 27, 2005 at 12:38:31PM +0200 ):
> > > On Saturday 26 February 2005 17:29, D Richard Felker III wrote:
> > > > On Sat, Feb 26, 2005 at 04:18:48PM +0100, Alexander Strasser wrote:
> > > > > Should all be changed to idle, as mentioned in the other mail.
> > > >
> > > > yes.
> > > 
> > > Done.
> > > Still used 'slave_idle' for the internal variable, because a variable of 
> > > "idle" just seems too short...
> > 
> > That's no argument. Find a non misleading name for it.
> 
> 100% agree.  Having option names and variable names differ obfuscates
> the code IMHO.  I think "idle" is just fine.

IMO idle is way too short for a global variable. What about something
like player_idle_mode or similar?

Rich