[MPlayer-dev-eng] Re: [PATCH] New video filter: deblendlogo

[Martin Atkins]

Oded Shimon wrote:
> On Thursday 24 February 2005 03:41, Oded Shimon wrote:
>>On Thursday 24 February 2005 02:10, Martin Atkins wrote:
>>
>>>If someone who knows more about YUV than me can make the reverse alpha
>>>blend work on YV12 then that would definitely be a better solution.
>>
>>I just finished it. :)
>>
>>I'm cleaning up the code a bit, I'll probably send a patch tommorrow
> 
> Done.
> 
> Adds YV12 support to this deblendlogo filter.
> Almost a complete re-write of the original filter.
> Unlike original filter, it accepts only a filename, no offset, and the png 
> image has to be the same res as the video frame.
> 

It certainly seems to work okay for me, but I think that the template 
offset is an important feature since it allows the same template to be 
used for, as an example, both standard ratio and widescreen video from 
the same channel, so long as they use the same logo for both.

This at least is true for TheWB where I did most of my original testing. 
I also found that in one case the logo was the same shape and size as it 
had been for all of my previous tests but it had moved two pixels up and 
to the left. In fact, it was that latter case that caused me to add the 
position parameters in the first place.

Still, I suppose this ability could be added back in later. I don't have 
the time to do it now, sadly. I think it might be a good idea to update 
the documentation comments and the error message to reflect the new 
usage, though!

All the best,
Martin Atkins