[MPlayer-dev-eng] [PATCH] More accurate af_volume

Zoltan Hidvegi mplayer at hzoli.2y.net
Mon Feb 21 17:40:15 CET 2005


Alex Beregszaszi wrote:
> > That of course makes sense, but i think we should still not assume it
> > is always 32bit when writing code and using the standard type int.
> 
> the appropriate inttypes should be used wherever needed (int32_t, etc),
> this solves the confusion, or at least only one side has to be fixed,
> the inttypes.h (or stdint.h in later carnations)

But I'm sure that mplayer is full of code which assumes that int is at
least 32-bits.  I think the best is to use long everywhere where no
specific bit size is needed, because long has the same size as the
native machine register on all 32 and 64-bit platforms I know.  But
sometimes I still use int, it's hard to get rid of old habits.

Zoli




More information about the MPlayer-dev-eng mailing list