[MPlayer-dev-eng] [PATCH] More accurate af_volume

Alexander Strasser eclipse7 at gmx.net
Mon Feb 21 00:43:11 CET 2005


D Richard Felker III wrote ( On Sun, Feb 20, 2005 at 06:40:19PM -0500 ):
> On Sun, Feb 20, 2005 at 09:26:49PM +0100, Alexander Strasser wrote:
> > D Richard Felker III wrote ( On Sun, Feb 20, 2005 at 02:17:11PM -0500 ):
> > > This is all non-gcc. On gcc, int is always 32bit, for good reason.
> > > If you make int any bigger, there's at least one size (either 16bit or
> > > 32bit) that can't exist at all within the standard types.. this is an
> > > unfortunate limitation of the C language.
> > 
> > That of course makes sense, but i think we should still not assume it is
> > always 32bit when writing code and using the standard type int.
> 
> I didn't read the code well, but I fail to see how it assumed int is
> 32bit. As far as I could tell all it needed was at least 32 bits,
> which is a given.

I think you are correct, tho i also didn't read the code closely.
My statement was meant in general, not specific to this case.

  Alex (beastd)




More information about the MPlayer-dev-eng mailing list