[MPlayer-dev-eng] [PATCH] charset conversion for help messages

[Torinthiel]

On Sat, Feb 19, 2005 at 12:40:20PM +0100, Reimar Döffinger wrote:
> Hi,
> the attached patch adds a --charset option to the configure options that
> will make MPlayer convert the help_mp-* file to the specified charset -
> it needs the right from charset to be specified in a
> help_mp-??.h.charset file.
> What do you think of this? It is a really small patch, and I think this
> is quite useful, especially as I think we really should support utf8 -
> it seems the only useable charset to me.

Not to me, but I agree it would be usefull and nice to have.
What I'd like even more is some kind of autodetection of output charset
(based on LC_* settings), which of course could be overridden by
--charset. And also if *.charset is missing default to ISO-8859-1.
Also, if we already have charset stored somewhere then why not convert
manpages on installing? (with some care, not to convert KOI8-R to
ISO-8859-2 for example).
Not that I'm willing to do it ;) (at least not now, I have a lot on TODO
list and this is not going to receive top priority).

> Index: configure
> ===================================================================
> RCS file: /cvsroot/mplayer/main/configure,v
> retrieving revision 1.964
> diff -u -r1.964 configure
> --- configure	18 Feb 2005 03:55:27 -0000	1.964
> +++ configure	19 Feb 2005 11:35:18 -0000
> @@ -1383,6 +1385,7 @@
>  #_language=en
>  _shm=auto
>  _linux_devfs=no
> +#_charset=utf8

What is this for? I don't think this should have a default, and not
a commented out one for sure.
Torinthiel

-- 
 Waclaw "Torinthiel" Schiller       GG#: 542916, 3073512
   torinthiel(at)megapolis(dot)pl
   gpg: B06901F1 fpr: FAA3 559F CAE9 34DE CDC8  7346 2B6E 39F2 B069 01F1
 "No classmates may be used during this examination"
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20050219/c3f7ccf1/attachment.pgp>