[MPlayer-dev-eng] [PATCH] -vd option

[Ivan Kalvachev]

On Wed, 16 Feb 2005 22:29:50 -0600
Joey Parrish <joey at nicewarrior.org> wrote:

> On Thu, Feb 17, 2005 at 04:35:15AM +0200, Oded Shimon wrote:
> > On Thursday 17 February 2005 04:28, D Richard Felker III wrote:
> > > On Wed, Feb 16, 2005 at 09:27:50PM -0500, D Richard Felker III wrote:
> > > > On Thu, Feb 17, 2005 at 03:56:28AM +0200, Jan Knutar wrote:
> > > > > On Thursday 17 February 2005 03:52, Oded Shimon wrote:
> > > > > > ;)
> > > > > >
> > > > > > - ods15
> > > > > >
> > > > > > (credits to rich for the text.)
> > > > >
> > > > > Excellent patch, your best so far! ;)
> > > >
> > > > rotfl! somebody apply this! :))))))))))))
> > >
> > > on second thought, no, even this patch has a bug. :)
> > > it's supposed to print this for -vd help (suboption help), not just
> > > plain -vd. :)
> > 
> > Fixed.
> 
> Who will have the honor of the commit?
> I'll give the community at large 48 hours to decide before I do it.

I prefer the first patch. The second one is bloat.
It waste too much space for something that is supposed to bomb.
And i consider it feature. E.g. I have seen users -vd ffmpeg.
We want to handle this case, don't we?

BTW the message sound  cryptic to me.
I don't think we need another joke.

Ivan