[MPlayer-dev-eng] [PATCH] Improve NV12/NV21 support

Michael Niedermayer michaelni at gmx.at
Wed Feb 16 22:42:40 CET 2005


Hi

On Monday 14 February 2005 08:51, Ville Syrjälä wrote:
> On Mon, Feb 14, 2005 at 12:22:42AM +0100, Michael Niedermayer wrote:
> > Hi
> >
> > On Sunday 13 February 2005 02:50, Ville Syrjälä wrote:
> > > The attached patch tries to make NV12/NV21 support a bit more
> > > functional.
> > >
> > > My aim was just to get it working with DirectFB + Matrox BES so I'm not
> > > really interested in software scaling.
>
> <snip>
>
> > > - Added vDest != NULL tests to swscale since it can't actually handle
> > >   NV12/NV21. So only luma will be scaled but at least it won't crash.
> >
> > rejected, fix the code so it handles chroma or leave it as it is
>
> Ok. I attached a new version which handles chroma too. C implementation
> only.
>
> > >+       case IMGFMT_NV12:
> > >+       case IMGFMT_NV21:
> > >+               *h=1;
> > >+               *v=1;
> > >+               break;
> >
> > ugh, add these to the already existing case for h/v=1
>
> Fixed.

looks ok, commit it if it works and doesnt break anything knowingly

-- 
Michael

"nothing is evil in the beginning. Even Sauron was not so." -- Elrond




More information about the MPlayer-dev-eng mailing list