[MPlayer-dev-eng] [PATCH] Multiple files for MEncoder

Oded Shimon ods15 at ods15.dyndns.org
Wed Feb 16 18:55:53 CET 2005


On Tuesday 15 February 2005 19:41, D Richard Felker III wrote:
> no need to protect the lusers from themselves, but imo it _would_ be
> good to protect people who may receive files encoded by the luser.
> i.e. mencoder should bail out with an error rather than writing an
> invalid file where audio format changes midway through, even if it
> means pissing off the user who already spent 5 hours encoding the
> first file.
Done. Also a message was added to help_mp-en.h for it.

> i agree, this is an issue. oded, you should download some samples to
> test with if you don't have dvd/subs yourself.
Done. Went over all options one by one to see which belong to GLOBAL and which 
aren't.. turns out I was right the first time anyway. :)

> not really possible without nasty hacks in the filter chain. again,
> anyone stupid enough not to check their files before encoding should
> not be encoding to begin with.
No change here.


I did find a bad part in my previous patch, program tried to access freed 
memory.. The muxer's header was copied from the input header, but only as a 
shallow copy.. Since the input was freed and a new input came, obvious 
problem...
Fixed the problem, made it a deep copy instead, passed every possible test I 
could give it.

Other than that this patch is same as before.

- ods15
-------------- next part --------------
A non-text attachment was scrubbed...
Name: help_mp-en.patch
Type: text/x-diff
Size: 1000 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20050216/f64c0a22/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cfg-mencoder.patch
Type: text/x-diff
Size: 5684 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20050216/f64c0a22/attachment-0001.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: endpos.patch
Type: text/x-diff
Size: 2584 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20050216/f64c0a22/attachment-0002.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mencoder.patch
Type: text/x-diff
Size: 10625 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20050216/f64c0a22/attachment-0003.patch>


More information about the MPlayer-dev-eng mailing list