[MPlayer-dev-eng] [PATCH] Multiple files for MEncoder

[Reynaldo H. Verdejo Pinochet]

On Mon, Feb 14, 2005 at 07:17:01PM +0200, Oded Shimon wrote:
> On Tuesday 08 February 2005 11:27, Oded Shimon wrote:
> > As most of you probably know, I've been working on multiple file support
> > for MEncoder. this patch is a "first draft". Things which could be
> > improved:

first, if this is ever going to be applyed, and rest asured that i'd
like so, you will need tho fix some of these

> > 1. Somehow remove redundancy by not having most of the same video 
> > init code twice. The init for each next file is a little different from the
> > first file, so I couldn't just 'goto' to before the init, but repetitive
> > code is always bad...
> Fixed.
> 
> > 2. Better support for audio - as is, if the user specifies '-af' it only
> > affect the first file. Also no checks are made against merging 2 files
> > which have different audio
> Fixed. still no checks though.

maybe not _so_ easy, but and effort should be made to protect lusers from
himselfs, imho checks should be done.

> 
> > 3. Fixing most of the MEncoder options to be properly global. As is, '-ovc'
> > and '-oac' for ex. are "per file" options, not the most desireable
> > situation...
> Fixed.
> I'm not 100% sure I got all of them right, as some of these options I have 
> never used and do not know their significance... please look over the patch 
> and tell me if it's OK.

youre the one coding this, if you arent confident enough to asure this
will work on every escenario, maybe you are rushing things up a little.

> 
> > 4. Perhaps improving dealing with bad merging of files?  As is, if the user
> > asks to merge 2 files which are of different resolution, MEncoder exits
> > with error when reaching the second file - a possibly depressing result if
> > the user waited a long time for the encode of the first file. The user can
> > still do this however, and it will work perfectly:
> > mencoder 1.avi 2.avi -vf scale=whatever
> > And only the 2nd file will be scaled, as necessary.
> Hasn't changed.

same with audio, some encodings take a while to complete, imagine an user
waiting an hour or so, just to see they cannot make it trough the next
file.. not nice at all, maybe you can just force the scale and inform
the user youre going to do so?

> 
> > 5. Patching the man page as necessary of course...
> Uhhh, haven't done that yet :)

that can wait, the patch, imho, should be improved.

> ....

keep up the good work oded, you know how this works ;)

Reynaldo

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20050215/3f37b60f/attachment.pgp>