[MPlayer-dev-eng] [PATCH] Multiple files for MEncoder

Oded Shimon ods15 at ods15.dyndns.org
Wed Feb 9 12:04:31 CET 2005


On Tuesday 08 February 2005 21:53, D Richard Felker III wrote:
> On Tue, Feb 08, 2005 at 07:58:54PM +0200, Oded Shimon wrote:
> > The only solution I can see is wrapping most of the stuff  in the initing
> > in the begginning which isn't done twice around an 'if'. Not very
> > elegant, but better than repetetive code I think.
>
> that would be ok too. probably better.
>
OK, I can do this, just one problem which usually leads to patches being 
rejected - I'll have to reorganize mencoder.c a bit to make it more logical, 
separate input initialization from output initialization. Either that or have 
the 'if's pretty scattered around.
One thing I'm noticing for ex. is this:

demuxer open
vob sub out init
subdata open
muxer open

so I'd like to re-arrange that to make subdata open before the sub out init...

Or maybe i will go for the struct idea?.. That one was pretty good.

- ods15




More information about the MPlayer-dev-eng mailing list