[MPlayer-dev-eng] [PATCH] makes --enable-*-faad behave correctly
nsabbi at tiscali.it
Wed Feb 2 18:52:01 CET 2005
Aurelien Jacobs wrote:
>On Wed, 02 Feb 2005 08:43:50 +0100
>Nico Sabbi <nsabbi at tiscali.it> wrote:
>>I'm against it: faad is very prone to break. If the external library
>>doesn't compile (now or in the future) mplayer won't compile either
>>because of the removal of this check.
>What ? I don't understand what you mean exactly.
>If external library doesn't compile, it's not related to MPlayer...
>And mplayer won't detect any external faad so won't use it.
>Or you mean if external faad API changes and that ad_faad don't
>compile anymore ?
>My patch modify the test code used when _faad_external=auto, so that
>it try to compile faacDecInit() (which argument number changed during
>the API change) so that it will fail on older versions of faad2 and
>thus disable faad on those broken versions.
>If a new API change is introduced, we will anyway have to modify the
>configure to take care of the new version.
>So the removal of the version check only disable support of very old
>faad2 versions but when _faad_external=auto we still verify the the
>version found follow the new API.
>So what's exactly the problem with that ?
sorry, I misread your patch (I missed the line that changed the main()
Now I see that configure will still try to cc_check for external_faad.
More information about the MPlayer-dev-eng