[MPlayer-dev-eng] check for XFree86-VidModeExtension broken for xfree 3.3.x

[Diego Biurrun]

Trent Piepho writes:
> On Tue, 1 Feb 2005, Diego Biurrun wrote:
> > > > You add a check so you should also add --disable and --enable options
> > > > to configure.
> > > 
> > > Ok, here is an updated patch.  IMHO, the multi-media keyboard support is such
> > > a minor thing it's not really worth the clutter of another configure option.
> > 
> > You could argue that, but I think we should be consistent.
> 
> There are dozens of checks for header files that lack enable and disable
> options, so it's not totally inconsistent.

Yes, I'm aware of this.

> > > +if test "$_x11" = yes && test "$_xk" != no ; then
> > 
> > This will run autodetection when _xk is set to "yes" or "auto".  It
> > should only run autodetection in the "auto" case, "yes" is for
> > overriding autodetection.
> 
> I was copying how some other checks work:
> 
> if test "$_x11" != no ; then
> if test "$_x11" = yes && test "$_xv" != no ; then
> if test "$_nas" = auto || test "$_nas" = yes ; then
> if (test "$_x11" = yes || win32) && test "$_gl" != no ; then
> if test "$_x11" = yes && test "$_vm" != no ; then
> if test "$_x11" = yes && test "$_xinerama" != no ; then
> if test "$_alsa" != no ; then
> if test "$_xvid" != no && cc_check $_inc_xvid $_ld_xvid ; then
> if test "$_x264" != no && cc_check $_inc_x264 $_ld_x264 ; then
> if test "$_divx4linux" != no && cc_check $_ld_lm -ldivxdecore ; then
> if test "$_i18n" != no ; then
> 
> There are many more checks where 'yes' will cause auto-detection to be
> skipped, but I only looked at the _vm check I was trying to fix, and
> duplicated how it worked, as opposed to surveying every check that supports
> auto-detection, as I have now done.
> 
> This patch allows auto-detection to be overridden for the _xf86xk check and
> for the _vm check too.  If someone wants to fix the other unrelated checks
> that don't override, I've listed them for you.

Thanks, I'll keep that list somewhere.

Patch committed.  I've renamed the option/variable to xf86keysym,
that's what the configure check prints.  I've also simplified what you
suggested for the vm check.

Diego