[MPlayer-dev-eng] [PATCH] bad configure detection for termcap

[Dominik 'Rathann' Mierzejewski]

On Sunday, 25 December 2005 at 16:09, Bernd Ernesti wrote:
> On Sun, Dec 25, 2005 at 03:00:03PM +0100, Dominik 'Rathann' Mierzejewski wrote:
> > On Sunday, 25 December 2005 at 14:50, Diego Biurrun wrote:
> > > On Sun, Dec 25, 2005 at 02:07:44PM +0100, Dominik 'Rathann' Mierzejewski wrote:
> > > > > 
> > > > > -  for _ld_tmp in "-ltermcap" "-ltinfo" ; do
> > > > > +  for _ld_tmp in "-ltermcap" "-ltinfo" "-lncurses"; do
> > > > 
> > > > I'd prefer to change the detection order, i.e. ncurses first, then fall back
> > > > to tinfo and finally termcap. ncurses and terminfo are superior to the old
> > > > termcap.
> 
> That maybe true, but what needs it in mplayer?
> 
> > > Commit that change then.
> > 
> > Done.
> 
> I'm not too happy with that change.
> 
> Do we really need to depend on ncurses?

We don't depend on it. It's just checked for first.

> ncurses is not in the base system for NetBSD and other systems.
> It maybe there for other programs which really need it, but I see no need
> for mplayer.
> The library for ncurses is over 250KB big where termcap is only 12KB.

Well, it's newer and not broken like termcap (which dumps core when terminal
description has more than 1024 bytes).

> At least make it possible to force the usage of termcap, or only change the order
> for linux systems.

It's still (and has been for a long time) possible using --enable-termcap
and --with-termcaplib=termcap.

Regards,
R.

-- 
MPlayer RPMs maintainer: http://rpm.greysector.net/mplayer/
"I am Grey. I stand between the candle and the star. We are Grey.
 We stand between the darkness ... and the light."
        -- Delenn in Grey Council in Babylon 5:"Babylon Squared"