[MPlayer-dev-eng] [PATCH] "staying" and "aletrnating" input prefixes

Reimar Döffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Sun Dec 25 15:24:39 CET 2005


Hi,
On Sun, Dec 25, 2005 at 08:52:22AM +0200, Oded Shimon wrote:
> along with "pausing", this patch bring 2 new input prefixes, "staying" and 
> "alternating". "staying" causes mplayer to pause if it was already paused 
> when command was given, and not otherwise. "alternating" does the exact 
> opposite.
> Addmittedly, "alternating" is rather odd, but believe it or not I actually 
> do have a use for it... And it's not a big deal to implement, so why not. :)

I'd prefer them to be named something like pausing_keep and
pausing_toggle, it pollutes the "namespace" less.
Also if we ever make an alphabetical list of prefixes they will be close
together.
btw. about that was_.. variable, isn't there already some other variable
that keeps track of the paused state? Adding another one makes it likely
that they will get out of sync after a few broken patches *g*

Greetings,
Reimar Döffinger

P.S.: I'll be on holiday for a bit more than a week after Tuesday, just
in case you wonder :-)




More information about the MPlayer-dev-eng mailing list