[MPlayer-dev-eng] [PATCH] Fix inverted colours when capturingYV12 in V4L2 mode
makovick at kmlinux.fjfi.cvut.cz
Fri Dec 16 23:01:28 CET 2005
Luc Gallant wrote:
> In this case, this is my point. When I put outfmt=yv12, tvi_v4l2 requests
> this format from my driver, and my driver agrees to send it in.
No. MPlayer requests fcc_mp2vl(IMGFMT_YV12), which is V4L2_PIX_FMT_YUV420.
> when I send in the format, the U and V planes were being switched in memory,
> which was causing the colours to be inverted. I know for sure that I am
> sending in YV12 video, because if I just play this video using read() and
> telling mplayer it's yv12 coming in, then it works fine. So, I don't know
> what the mplayer team wants to do, but I'm saying that when using yv12, the
> colours are inverted, and my patch stops this from happening.
Please, get a real TV card and see for yourself that the colors are ok.
> In my patch, it is only the YV12 case that I'm uncommenting. If this breaks
> bttv driver colours, then maybe the bttv fix should be applied somewhere
> else instead of there...
The patch is mostly ok, it just fixes things which aren't broken.
More information about the MPlayer-dev-eng