[MPlayer-dev-eng] [PATCH] Fix inverted colours when capturing YV12 in V4L2 mode

Rich Felker dalias at aerifal.cx
Fri Dec 16 22:35:57 CET 2005


On Fri, Dec 16, 2005 at 10:15:30PM +0100, Jindrich Makovicka wrote:
> Rich Felker wrote:
> >On Fri, Dec 16, 2005 at 09:07:46PM +0100, Jindrich Makovicka wrote:
> >
> >>Rich Felker wrote:
> >>
> >>>I agree. MPlayer should not contain workarounds for bugs in the (very
> >>>shitty) bttv driver.
> >>
> >>There was no bug. The driver just didn't support YV12 colorspace so 
> >>tvi_v4l1 did the conversion on the fly. But if you really insist on 
> >>removing this, we can try and see who will scream :)
> >
> >
> >There is no conversion; as far as mplayer is concerned, YV12 and I420
> >are identical.
> 
> No, they have U&V swapped. It's the memcpy hunk that is removed in Luc's 
> patch.

Well that's idiotic. Like I said mplayer doesn't care about the order
in memory. It's just pointers to planes, always in Y,U,V order.

Rich




More information about the MPlayer-dev-eng mailing list