[MPlayer-dev-eng] [PATCH] Real demuer audio cleanup

Diego Biurrun diego at biurrun.de
Thu Dec 8 22:19:09 CET 2005


On Thu, Dec 08, 2005 at 03:50:21PM +0100, Roberto Togni wrote:
> On Tue, 6 Dec 2005 10:52:23 +0100
> Diego Biurrun <diego at biurrun.de> wrote:
> 
> > On Tue, Dec 06, 2005 at 01:49:04AM +0100, Roberto Togni wrote:
> > > 
> > > New patch for demuxer_real.c attached. Seek is fixed
> > > (audio_need_keyframe was never cleared), it also fixes a bug in
> > > timestamps computation (was always 0).
> > 
> > Seek is indeed fixed, but now I get crashes in decode_audio with the
> > SIPR binary codec on PPC Linux.  Tell me if you need further details,
> > I'm in a rush right now.
> [...]
> 
> This patch should fix it.

It does :)

The old RealAudio 288 stuff now crashes with the native codec and the
FFmpeg decoder

[real_288 @ 0x106141f8]ffra288: Error: need extra data!!!

instead of

[real_288 @ 0x10613b60]ffra288: Error! Input buffer is too small [228<2736]

but IIRC you wanted to remove the native decoders anyway.

So when are you going to commit cook? :)

Diego




More information about the MPlayer-dev-eng mailing list