[MPlayer-dev-eng] [PATCH] demuxers cleanup (was Re: [PATCH] misc small fixes (mostly gcc warnings) )

Roberto Togni r_togni at tiscali.it
Mon Dec 5 18:20:47 CET 2005


On Mon, 5 Dec 2005 16:41:55 +0100
Dominik 'Rathann' Mierzejewski <dominik at rangers.eu.org> wrote:

> On Monday, 05 December 2005 at 03:39, The Wanderer wrote:
> > Thanks. Now, what about the rest of the 'mplayer-demuxers' patch? Should 
> > it be considered dropped (at least pending another patch submission), or 
> > is it still potentially viable?
> 
> Well, both Reimar and Roberto seemed to accept it. Only Rich objected.
> 
That's still my opinion. I see no reason to keep an unused return value
(was never used), also considering that it's meaningful only for few
demuxers (others always return the same value).

If some day MPlayer will be modified to use return values from seeking
functions, they can easily be added back.

If the problem is history (but we have cvs for that), they can be
commented out instead of remove them.

They should have been fixed with the big demuxer patch, but i
overlooked them. 

Ciao,
 Roberto




More information about the MPlayer-dev-eng mailing list