[MPlayer-dev-eng] [PATCH] charset checking for TOOLS/checktree.sh

Ivo ivop at euronet.nl
Mon Dec 5 03:09:45 CET 2005


On Monday 05 December 2005 01:29, The Wanderer wrote:
> The Wanderer wrote:
> > Ivo wrote:
> >> On Friday 11 November 2005 19:15, Ivo wrote:
> >>> I once thought of adding an option, so each check could either
> >>> print a list of filenames and just that, or it could also dump
> >>> the offending lines per file, but I never got around to making
> >>> it. If you want, you can add that :)
> >>
> >> Ok, maybe something like this patch.
> >>
> >> And then TOOLS/checktree.sh -all -showcont
> >
> > It's been two weeks - any comments on this patch?
>
> Another week-plus later without any comments: the patch looks okay to my
> (comparatively inexperienced) eyes, still applies without errors, and
> appears to behave correctly; I'll commit it in a day or two if no one
> speaks up against it.

I created this small patch so it was easier to have Reimar's patch conform 
to some sort of standard. Like, see which files do not comply to a certain 
rule and (with this switch) see which lines of those files are "wrong". I 
am the author of the original script and I think that is a Good Thing :)

Although Reimar did not update his patch yet, I think my patch can be 
applied. I can do it myself, but if you want, you can do it too. BTW should 
I list myself as maintainer for this script? I didn't know if I had to for 
scripts in TOOLS.

> (Although, I'll note, there is apparently one UNHOLY SHITLOAD of
> trailing whitespace in the source tree...)

Yes :)

And sorry for taking so long to reply. I had forgotten about this completely 
and am quite busy atm.

--Ivo




More information about the MPlayer-dev-eng mailing list