[MPlayer-dev-eng] [PATCH] make ID_LENGTH float instead of int

[Oded Shimon]

On Sat, Aug 27, 2005 at 09:23:41PM +0200, Reimar D?ffinger wrote:
> Hi,
> On Sat, Aug 27, 2005 at 10:08:08PM +0300, Oded Shimon wrote:
> > I think reimar is contageous (sp?)
> 
> In my case that's only mutt's fault! It's so easy to press 'y' in instead of
> 'a' accidently! :-P

They are not even close to each other! And yeah that actually has happenned 
to me sometimes :/ (in this case i just completely forgot to attach.. :)

> > -  mp_msg(MSGT_GLOBAL,MSGL_INFO,"ID_LENGTH=%ld\n", demuxer_get_time_length(demuxer));
> > +  mp_msg(MSGT_GLOBAL,MSGL_INFO,"ID_LENGTH=%.5lf\n", demuxer_get_time_length(demuxer));
> 
> 5 is overdoing it IMHO, but since the output is for programs anyway...

I wanted it to be accurate enough to do '*fps' and get the total number of 
frames... maybe add a seperate ID_ for that?...

> >  	  else if ( sh_audio ) guiIntfStruct.TimeSec=sh_audio->delay;
> > -	guiIntfStruct.LengthInSec=demuxer_get_time_length(demuxer);
> > +	guiIntfStruct.LengthInSec=(int)demuxer_get_time_length(demuxer);
> >  	guiGetEvent( guiReDraw,NULL );
> 
> I think this is neither necessary nor does it make sense.

Yeah, MPlayer is so hackish I was afraid to change any bit of the behavior 
in the tiniest bit :)

> Would be nice if somebody could change the demuxer changes with lots of
> samples...

"could *check"      you mean, right? otherwise you confused me. :)
I tried mpeg and avi, I'm just about satisified... I changed demux_*.c 
according to 'rgrep DEMUXER_CTRL_GET_TIME_LENGTH libmpdemux'...

- ods15