Fwd: [MPlayer-dev-eng] [PATCH] vobsub: keep aspect ratio

[Guillaume POIRIER]

Upon od15 request, here's a resent of a patch that got some attention
a while ago, but didn't get committed

---------- Forwarded message ----------
From: Csillag Kristof <fenwick at freemail.hu>
Date: Jan 22, 2005 7:39 AM
Subject: [MPlayer-dev-eng] [PATCH] vobsub: keep aspect ratio
To: mplayer-dev-eng at mplayerhq.hu


Hi there!

One more little thing:

When we rip a movie, black bars are often removed from the top and the
bottom of the original picture. This is OK, but it means that the aspect
ratio of the movie is changed. ON the other side, when we dump a VOBsub
subtitle, no cropping takes place, so it's aspect rate will match the
original (un-cropped) movie's.

So, when we display a subtitle with the cropped movie, and rescale the
vobsub's frame to match the movie's sizes, we are distorting the
subtitle's aspect ratio. (Typically, we get shorter letters.)
This makes reading the text harder.

  * * *

So, I added the option "-spu-keep-aspect". If it is switched on, the
VOBsub's original aspect ratio is used to display it. If it's off
(default), the aspect ratio of the movie is applied to the subtitles.

See the attached patch. (I updated the man page, too.)

(Note: this patch depends on the following two pending patches of mine:
a0_positioning-fix-and-cleanup.patch, a1_scaling.patch)

I uploaded a sample file here:
http://rht.bme.hu/~lunkwill/computer/mplayer/aspect-demo.mkv

The default "mplayer -slang eng aspect-demo.mkv" gives this:
http://rht.bme.hu/~lunkwill/computer/mplayer/without-keep-aspect.png

"mplayer -slang eng aspect-demo.mkv -spu-keep-aspect" gives this:
http://rht.bme.hu/~lunkwill/computer/mplayer/with-keep-aspect.png

  * * *

What do you think? IMHO the subtitles look much better this way.
Shouldn't this be the default behavior?


--
Csillag Kristof <fenwick at freemail.hu>


_______________________________________________
MPlayer-dev-eng mailing list
MPlayer-dev-eng at mplayerhq.hu
http://mplayerhq.hu/mailman/listinfo/mplayer-dev-eng





-- 
Reading doesn't hurt, really!
 -- Dominik 'Rathann' Mierzejewski
-------------- next part --------------
A non-text attachment was scrubbed...
Name: a3_keep_aspect.patch
Type: text/x-patch
Size: 4260 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20050825/9b92071f/attachment.bin>