[MPlayer-dev-eng] [PATCH] MPEG-ES in GXF demuxer

[Nico Sabbi]

Reimar Döffinger wrote:

>Hi,
>On Thu, Aug 25, 2005 at 04:49:40PM +0200, Nico Sabbi wrote:
>  
>
>>Rich Felker wrote:
>>    
>>
>>>>because otherwise -dumpvideo will dump the content you want to discard, 
>>>>and
>>>>the result will be a corrupt mpeg-es file
>>>>        
>>>>
>>>Use mencoder with -ovc copy -of rawvideo...
>>>      
>>>
>>a workaround against buggy code is not a solution, is it ? :)
>>    
>>
>
>I don't think -dumpvideo was supposed to have any use besides
>debugging...
>Anyway, would the attached patch be okay for you? Or should I move the
>autodetection further down (i.e. how likely is MPEG-PES to contain 0x1bf
>or 0x1bc headers)?
>  
>

since -PES will never contain 0x1bc and 0x1bf headers this last patch is 
fine if
you add the constraint
 && demuxer->synced==3 (the second probe) in the detection code.
In this last case it's ok to commit.

Thanks,
    Nico

 
 
 --
 Email.it, the professional e-mail, gratis per te: http://www.email.it/f
 
 Sponsor:
 Telefona con Email.it Phone Card, tanti minuti di conversazione con il massimo del risparmio, clicca qui
 Clicca qui: http://adv.email.it/cgi-bin/foclick.cgi?mid=2687&d=25-8