[MPlayer-dev-eng] [PATCH] Problem using libavcodec.so

[Diego Biurrun]

On Tue, Aug 23, 2005 at 06:31:01PM +0300, Ivan Kalvachev wrote:
> 2005/8/18, Diego Biurrun <diego at biurrun.de>:
> > On Mon, Aug 15, 2005 at 05:53:12PM +0200, Panagiotis Issaris wrote:
> > >
> > > For some time now, mencoder CVS failed to link dynamically to libavcodec.so:
> > >
> > > cc -I../libvo -I../../libvo -I/usr/X11R6/include -fno-PIC -O4
> > > [...]
> > > libmpcodecs/libmpencoders.a(ae.o)(.text+0xb9): In function
> > > `new_audio_encoder':
> > > : undefined reference to `mpae_init_lavc'
> > > collect2: ld returned 1 exit status
> > >
> > > This seems to be caused by libmpencoders.a not containing ae_lavc.o.
> > >
> > > The attached patch contains a fix for this.
> > 
> > Thanks, applied.
> 
> DonDiego, please don't apply patches blindly.

I apply patches after reviewing them, never blindly.

> There is something wrong in this patch. The problem is that right
> before the new Makefile line there is line that does the same if there
> is ANY libavcodec.
> The question is why it doesn't work, but the separate *SO one does.

Nonsense.  Read the source, you will see that the patch is correct.

> BTW it is ugly to see
> CONFIG_LIBAVCODECSO=auto

This is a purely cosmetic "problem".

Diego