[MPlayer-dev-eng] [PATCH] dropped frames count is increased even when no frames dropped

Oded Shimon ods15 at ods15.dyndns.org
Tue Aug 23 20:53:33 CEST 2005


On Tue, Aug 23, 2005 at 08:34:34PM +0200, Reimar D?ffinger wrote:
> Hi,
> the dropped frames count increases even with frame dropping disabled,
> and although no frames were actually dropped.
> Is this intentional?
> If not, is the attached patch acceptable?

I always wondered why the hell that number on that status line was 
constantly in snow files.. It never made any sense to me..

> -	    if(d<-dropped_frames*frame_time-0.100 && osd_function != OSD_PAUSE){
> +	    if(frame_dropping && d<-dropped_frames*frame_time-0.100 &&
> +	       osd_function != OSD_PAUSE){

As long as you're changing this code, could you make a tiny cosmetic... I 
spent an entire minute scratching my head "wtf is the '<-' operator??..".

(I don't know if this behavior is intentional or if the patch is 
acceptable, so don't consider this mail as an OK for the patch...)

- ods15




More information about the MPlayer-dev-eng mailing list