[MPlayer-dev-eng] Re: [PATCH] GNU/kFreeBSD support

[Rich Felker]

On Mon, Aug 22, 2005 at 10:53:44PM +0200, Robert Millan wrote:
> On Mon, Aug 22, 2005 at 04:22:11PM +0200, Diego Biurrun wrote:
> > > 
> > [...]
> > 
> > In these two cases you add #if defined(__GLIBC__) to #if defined(__linux__).
> >
> > [...]
> > 
> > Here you replace #if defined(__linux__) by #if defined(__GLIBC__).
> 
> The difference is that in the latter case, someone wrote a reply to this thread
> saying only __GLIBC__ should be present, because uClibc doesn't have mntent.
> So this is what I did.

uClibc does; however my patched version will not, because I'm removing
all the BSD cruft so that it's not resident in memory for the sake of
the one program that will use it (/bin/mount).

> > Are you sure you cannot just use #if defined(__GLIBC__) everywhere?
> 
> Sorry I don't know.  That should be answered by someone who works with Linux on
> a non-Glibc system.  I really don't mind as long as __GLIBC__ is present in
> these checks.

Again, these "features" should be evaluated to see if they're really
useful. IMO they're not and they even mess up playback in some cases!

Example: I accidentally burned a dvd without the mkisofs option to
store the files in the proper dvd filesystem order. In order to play
it, I tried mounting it and mplayer dvd://1 -dvd-device /cdrom. This
failed, because libdvdread stupidly looked up /cdrom in /etc/mtab and
decided to go behind my back and access the device directly! I had to
create symlinks to all the files on the dvd in order to play it, which
was nonsense. If I use /cdrom instead of /dev/dvd as the dvd-device, I
probably have a good reason; the program should not try to
second-guess me!

Rich