[MPlayer-dev-eng] Re: [PATCH] GNU/kFreeBSD support

[Diego Biurrun]

On Mon, Aug 22, 2005 at 11:00:52AM -0400, Rich Felker wrote:
> 
> IMO the whole idea of testing based on os name is bad. It makes bad
> assumptions about the particular library and header interface of each
> os, which is definitely subject to change, especially since "linux"
> does not imply any particular userspace.
> 
> A correct patch should remove all the #ifdef's based on os name and
> instead detect the features with the configure script or (as I
> recommended for this mount checking stuff) remove the "features"
> entirely since they are not useful.

I tend to agree, but this is orthogonal to this patch.  What you suggest
will require big overhauls all over the code base.  IOW, applying this
patch will not hurt.

Diego