[MPlayer-dev-eng] [PATCH] short, low bitrate audio file playback

Rich Felker dalias at aerifal.cx
Mon Aug 22 16:57:22 CEST 2005


On Mon, Aug 22, 2005 at 02:00:04PM +0200, Reimar Döffinger wrote:
> Hi,
> the attached patch helps playing short audio file to the end by not only
> waiting for the stream eof but also until the audio buffer is empty.
> Is it okay to apply?

I'm not sure. IMO it should be the ao's responsibility to play all
buffered audio at close time if the close is not user-requested.. But
this may lead to worse responsiveness with large buffers. On the other
hand I think it would give better results for making seamless gaps
across multiple files, if something like -fixed-vo were supported for
audio.

Anyway, are you sure this patch is needed with all ao's? Or just a few
broken ones? If it's needed for all, I'm ok with going ahead and
applying it as long as it doesn't break things.

Rich




More information about the MPlayer-dev-eng mailing list