[MPlayer-dev-eng] Re: [PATCH] GNU/kFreeBSD support

[Rich Felker]

On Sun, Aug 21, 2005 at 04:51:07PM +0200, Dominik 'Rathann' Mierzejewski wrote:
> > Author: rmh
> > Status: pending
> > Description: Enable misc kfreebsd-specific functionality.
> [...]
> > diff -ur MPlayer-1.0pre7.old/libmpdvdkit2/dvd_reader.c MPlayer-1.0pre7/libmpdvdkit2/dvd_reader.c
> > --- MPlayer-1.0pre7.old/libmpdvdkit2/dvd_reader.c	2005-03-11 03:40:28.000000000 +0100
> > +++ MPlayer-1.0pre7/libmpdvdkit2/dvd_reader.c	2005-08-05 18:44:36.000000000 +0200
> [...]
> > @@ -393,8 +393,8 @@
> >  	    }
> >  	    fclose( mntfile );
> >  	}
> > -#elif defined(__linux__)
> > -        mntfile = fopen( MOUNTED, "r" );
> > +#elif defined(__linux__) || defined(__GLIBC__)
> > +        mntfile = fopen(_PATH_MOUNTED, "r" );
> >          if( mntfile ) {
> >              struct mntent *me;
> >   
> 
> Why this change?

Both this and the original are wrong. It should be:

#elif defined(__GLIBC__)

or better, there should be a configure check for mntent, etc. I'm in
the process of cleaning up uClibc for use as the main libc on my new
install, and I'm removing useless legacy BSD crap like mntent that
just wastes space and shouldn't be needed by normal user programs.

Really, all of this code is nonsense and should be removed. There's no
legitimate reason to use -dvd-device /path/to/mounted/dvd instead of
-dvd-device /dev/dvd unless /dev/dvd is not readable by user, in which
case it's not possible to open the device for css authentication
anyway!

Rich