[MPlayer-dev-eng] [PATCH] Pivoting

[Jan Knutar]

On Friday 19 August 2005 17:40, Paweł Sakowski wrote:

> Problem #2: aspect.c sets monitor_aspect to the fixed value of 4:3,
> unless overridden by command line or config file. It's a pretty
> arbitrary value, and it's wrong for my monitor (which has aspect ratio
> 5:4, when rotated: 4:5). This problem isn't strictly related to
> pivoting, basically 4:3 is not the right aspect ratio for some monitors
> (including mine, even if not rotated). I believe it would be a better
> heuristics to precalculate monitor_aspect by dividing width/height (thus
> pressuming that pixels are squares).

If any new aspect code is made, it should query X for the true monitor
dimensions, to provide for non-4:3 && non-square pixels too, IMO.
There has to be a way to do it, as xdpyinfo seems able to get the phys
dimensions of my screen :)

Despite what Rich says, maybe a -querymonitoraspect would be acceptable
compromise between magic and mundanity.