[MPlayer-dev-eng] [PATCH] configure cleanup
Reimar Döffinger
Reimar.Doeffinger at stud.uni-karlsruhe.de
Thu Aug 18 16:12:20 CEST 2005
Hi,
I did some cleanup on configure, would be nice if you could test and
comment on it.
It's mostly minor things, like removing $_ld_m from some _ld_..
assignement, since we always link against that, and using for loops
instead of huge if-then-else constructs for detecting the right linker
flags etc.
Greetings,
Reimar Döffinger
-------------- next part --------------
Index: configure
===================================================================
RCS file: /cvsroot/mplayer/main/configure,v
retrieving revision 1.1042
diff -u -r1.1042 configure
--- configure 17 Aug 2005 23:39:19 -0000 1.1042
+++ configure 18 Aug 2005 14:07:16 -0000
@@ -2382,10 +2384,8 @@
_kstat=no
cc_check -lkstat && _kstat=yes
if test "$_kstat" = yes ; then
- _ld_arch="-lkstat $_ld_arch"
-fi
-if test "$_kstat" = yes ; then
_def_kstat="#define HAVE_LIBKSTAT 1"
+ _ld_arch="-lkstat $_ld_arch"
else
_def_kstat="#undef HAVE_LIBKSTAT"
fi
@@ -2456,18 +2456,16 @@
#include <netdb.h>
int main(void) { (void) gethostbyname(0); return 0; }
EOF
-cc_check -lsocket && _ld_sock="-lsocket"
-cc_check -lnsl && _ld_sock="-lnsl"
-cc_check -lsocket -lnsl && _ld_sock="-lsocket -lnsl"
-cc_check -lsocket -ldnet && _ld_sock="-lsocket -ldnet"
-cc_check -lsocket -lbind && _ld_sock="-lsocket -lbind"
-if test $_winsock2 = auto && not cygwin ; then
+for _ld_tmp in "-lsocket" "-lnsl" "-lsocket -lnsl" "-lsocket -ldnet" "-lsocket -lbind" ; do
+ cc_check $_ld_tmp && _ld_sock="$_ld_tmp" && break
+done
+if test -z "$_ld_sock" && test $_winsock2 = auto && not cygwin ; then
_winsock2=no
cat > $TMPC << EOF
#include <winsock2.h>
int main(void) { (void) gethostbyname(0); return 0; }
EOF
- cc_check -lws2_32 && _ld_sock="-lws2_32" && _winsock2=yes
+ cc_check -lws2_32 && _winsock2=yes
fi
if test "$_ld_sock" ; then
echores "yes (using $_ld_sock)"
@@ -2694,12 +2692,9 @@
int main(void) { dlopen(0, 0); dlclose(0); dlsym(0, 0); return 0; }
EOF
_dl=no
-if cc_check ; then
- _dl=yes
-elif cc_check -ldl ; then
- _dl=yes
- _ld_dl='-ldl'
-fi
+for _ld_tmp in "" "-ldl" ; do
+ cc_check $_ld_tmp && ld_dl="$_ld_tmp" && _dl=yes && break
+done
if test "$_dl" = yes ; then
_def_dl='#define HAVE_LIBDL 1'
else
@@ -2738,39 +2733,21 @@
_def_threads='#undef HAVE_THREADS'
echocheck "pthread"
-_ld_pthread=''
if test "$_pthreads" != no ; then
cat > $TMPC << EOF
#include <pthread.h>
void* func(void *arg) { return arg; }
int main(void) { pthread_t tid; return pthread_create (&tid, 0, func, 0) == 0 ? 0 : 1; }
EOF
-if hpux ; then
- _ld_pthread=''
-elif ( cc_check -lpthreadGC2 && $TMPO ) ; then # mingw pthreads-win32
- _ld_pthread='-lpthreadGC2'
-elif ( cc_check && $TMPO ) ; then # QNX
- _ld_pthread=' ' # _ld_pthread='' would disable pthreads, but the test worked
-elif ( cc_check -lpthread && $TMPO ) ; then
- _ld_pthread='-lpthread'
-elif ( cc_check -pthread && $TMPO ) ; then
- _ld_pthread='-pthread'
-else
- if test "$_ld_static" ; then
+_pthreads=no
+if not hpux ; then
+ for _ld_tmp in "-lpthreadGC2" "" "-lpthread" "-pthread" ; do
# for crosscompilation, we cannot execute the program, be happy if we can link statically
- if ( cc_check -lpthread ) ; then
- _ld_pthread='-lpthread'
- elif ( cc_check -pthread ) ; then
- _ld_pthread='-pthread'
- else
- _ld_pthread=''
- fi
- else
- _ld_pthread=''
- fi
+ cc_check $_ld_tmp && ($TMPO || test "$_ld_static") && _ld_pthread="$_ld_tmp" && _pthreads=yes && break
+ done
fi
fi
-if test "$_ld_pthread" != '' ; then
+if test "$_pthreads" = yes ; then
echores "yes (using $_ld_pthread)"
_pthreads='yes'
_def_pthreads='#define HAVE_PTHREADS 1'
@@ -2822,15 +2799,9 @@
}
EOF
_iconv=no
- if cc_check $_ld_lm ; then
- _iconv=yes
- elif cc_check $_ld_lm -liconv ; then
- _iconv=yes
- _ld_iconv='-liconv'
- elif cc_check $_ld_lm -liconv $_ld_dl ; then
- _iconv=yes
- _ld_iconv='-liconv $_ld_dl'
- fi
+ for _ld_tmp in "" "-liconv" "-liconv $_ld_dl" ; do
+ cc_check $_ld_lm $_ld_tmp && _ld_iconv="$_ld_tmp" && _iconv=yes && break
+ done
fi
if test "$_iconv" = yes ; then
_def_iconv='#define USE_ICONV 1'
@@ -2999,8 +2970,9 @@
int main(void) { return 0; }
EOF
_termcap=no
- cc_check -ltermcap && _termcap=yes && _ld_termcap='-ltermcap'
- cc_check -ltinfo && _termcap=yes && _ld_termcap='-ltinfo'
+ for _ld_tmp in "-ltermcap" "-ltinfo" ; do
+ cc_check $_ld_tmp && _ld_termcap="$_ld_tmp" && _termcap=yes && break
+ done
fi
if test "$_termcap" = yes ; then
_def_termcap='#define USE_TERMCAP 1'
@@ -3348,25 +3320,9 @@
#include <libsmbclient.h>
int main(void) { smbc_opendir("smb://"); return 0; }
EOF
- if cc_check -lsmbclient ; then
- _smbsupport=yes
- _ld_smb="-lsmbclient"
- else
- if cc_check -lsmbclient $_ld_dl ; then
- _smbsupport=yes
- _ld_smb="-lsmbclient $_ld_dl"
- else
- if cc_check -lsmbclient $_ld_dl -lnsl ; then
- _smbsupport=yes
- _ld_smb="-lsmbclient $_ld_dl -lnsl"
- else
- if cc_check -lsmbclient $_ld_dl -lssl -lnsl ; then
- _smbsupport=yes
- _ld_smb="-lsmbclient $_ld_dl -lssl -lnsl"
- fi
- fi
- fi
- fi
+ for _ld_tmp in "-lsmbclient" "-lsmbclient $_ld_dl" "-lsmbclient $_ld_dl -lnsl" "-lsmbclient $_ld_dl -lssl -lnsl" ; do
+ cc_check $_ld_tmp && _ld_smb="$_ld_tmp" && _smbsupport=yes && break
+ done
fi
if test "$_smbsupport" = yes; then
@@ -3568,6 +3524,7 @@
echocheck "DPMS"
_xdpms3=no
+_xdpms4=no
if test "$_x11" = yes ; then
cat > $TMPC <<EOF
#include <X11/Xmd.h>
@@ -3580,9 +3537,6 @@
}
EOF
cc_check $_inc_x11 -lXdpms $_ld_x11 && _xdpms3=yes
-fi
-_xdpms4=no
-if test "$_x11" = yes ; then
cat > $TMPC <<EOF
#include <X11/Xlib.h>
#include <X11/extensions/dpms.h>
@@ -3901,13 +3855,9 @@
int main(void) { (void) aa_init(0, 0, 0); return 0; }
EOF
_aa=no
- if cc_check -laa ; then
- _aa=yes
- _ld_aa="-laa"
- elif cc_check $_ld_x11 -laa ; then
- _aa=yes
- _ld_aa="$_ld_x11 -laa"
- fi
+ for _ld_tmp in "-laa" "$_ld_x11 -laa" ; do
+ cc_check $_ld_tmp && _ld_aa=$_ld_tmp && _aa=yes && break
+ done
fi
if test "$_aa" = yes ; then
_def_aa='#define HAVE_AA 1'
@@ -3958,7 +3908,7 @@
fi
if test "$_svga" = yes ; then
_def_svga='#define HAVE_SVGALIB 1'
- _ld_svga="-lvga $_ld_lm"
+ _ld_svga="-lvga"
_vosrc="$_vosrc vo_svga.c"
_vomodules="svga $_vomodules"
else
@@ -4203,19 +4153,9 @@
return 0;
}
EOF
- if cc_check -lungif && "$TMPO" >> "$TMPLOG" ; then
- _gif=yes
- _ld_gif="-lungif"
- elif cc_check -lungif $_ld_x11 && "$TMPO" >> "$TMPLOG" ; then
- _gif=yes
- _ld_gif="-lungif $_ld_x11"
- elif cc_check -lgif && "$TMPO" >> "$TMPLOG" ; then
- _gif=yes
- _ld_gif="-lgif"
- elif cc_check -lgif $_ld_x11 && "$TMPO" >> "$TMPLOG" ; then
- _gif=yes
- _ld_gif="-lgif $_ld_x11"
- fi
+ for _ld_tmp in "-lungif" "-lungif $_ld_x11" "-lgif" "-lgif $_ld_x11" ; do
+ cc_check $_ld_tmp && "$TMPO" >> "$TMPLOG" && _ld_gif="$_ld_tmp" && _gif=yes && break
+ done
fi
# If no library was found, and the user wants support forced,
@@ -4418,7 +4358,7 @@
echores "$_directx"
echocheck "NAS"
-if test "$_nas" = auto || test "$_nas" = yes ; then
+if test "$_nas" = auto ; then
cat > $TMPC << EOF
#include <audio/audiolib.h>
int main(void) { return 0; }
@@ -4440,13 +4380,13 @@
echocheck "DXR2"
if test "$_dxr2" = auto; then
_dxr2=no
- for _inc_dxr2 in "$_inc_dxr2" \
- "-I/usr/local/include/dxr2" \
- "-I/usr/include/dxr2"; do
cat > $TMPC << EOF
#include <dxr2ioctl.h>
int main(void) { return 0; }
EOF
+ for _inc_dxr2 in "$_inc_dxr2" \
+ "-I/usr/local/include/dxr2" \
+ "-I/usr/include/dxr2"; do
cc_check $_inc_dxr2 && _dxr2=yes && break
done
fi
@@ -4680,23 +4620,26 @@
echocheck "JACK"
if test "$_jack" = auto ; then
_jack=no
- if ( pkg-config --modversion jack > /dev/null 2>&1 ) &&
- jackd --version | grep version | awk '{ print $3 }' >> "$TMPLOG" 2>&1 ; then
cat > $TMPC << EOF
#include <jack/jack.h>
int main(void) { jack_client_new("test"); return 0; }
EOF
- cc_check `pkg-config --libs --cflags jack` && "$TMPO" >> "$TMPLOG" 2>&1 && _jack=yes
-fi
+ _jack=yes
+ if cc_check -ljack ; then
+ _ld_jack="-ljack"
+ elif cc_check `pkg-config --libs --cflags jack` ; then
+ _ld_jack="`pkg-config --libs jack`"
+ _inc_jack="`pkg-config --cflags jack`"
+ else
+ _jack=no
+ fi
fi
if test "$_jack" = yes ; then
_def_jack='#define USE_JACK 1'
_aosrc="$_aosrc ao_jack.c"
_aomodules="jack $_aomodules"
- _ld_jack="`pkg-config --libs jack`"
- _inc_jack=`pkg-config --cflags jack`
else
_noaomodules="jack $_noaomodules"
fi
@@ -5003,15 +4946,9 @@
int main(void) { return 1; }
EOF
_cdparanoia=no
- if cc_check $_inc_cdparanoia $_ld_cdparanoia -lcdda_interface -lcdda_paranoia $_ld_lm ; then
- _cdparanoia=yes
- else
- for I in /usr/include/cdda /usr/local/include/cdda ; do
- if cc_check -I$I $_ld_cdparanoia -lcdda_interface -lcdda_paranoia $_ld_lm ; then
- _cdparanoia=yes; _inc_cdparanoia="-I$I"; break
- fi
- done
- fi
+ for _inc_tmp in "$_inc_cdparanoia" "-I/usr/include/cdda" "-I/usr/local/include/cdda" ; do
+ cc_check $_inc_tmp $_ld_cdparanoia -lcdda_interface -lcdda_paranoia $_ld_lm && _inc_cdparanoia="$_inc_tmp" && _cdparanoia=yes && break
+ done
fi
if test "$_cdparanoia" = yes ; then
_def_cdparanoia='#define HAVE_CDDA'
@@ -5081,7 +5018,6 @@
fi
echocheck "fontconfig"
if test "$_fontconfig" = auto ; then
- if ( pkg-config --modversion fontconfig) > /dev/null 2>&1 ; then
cat > $TMPC << EOF
#include <stdio.h>
#include <fontconfig/fontconfig.h>
@@ -5096,16 +5032,18 @@
}
EOF
- _fontconfig=no
- cc_check `pkg-config --cflags --libs fontconfig` && $TMPO >> "$TMPLOG" && _fontconfig=yes
- else
- _fontconfig=no
- fi
+ _fontconfig=yes
+ if cc_check -lfontconfig ; then
+ _ld_fontconfig="-lfontconfig"
+ elif cc_check `pkg-config --cflags --libs fontconfig` ; then
+ _inc_fontconfig=`pkg-config --cflags fontconfig`
+ _ld_fontconfig=`pkg-config --libs fontconfig`
+ else
+ _fontconfig=no
+ fi
fi
if test "$_fontconfig" = yes ; then
_def_fontconfig='#define HAVE_FONTCONFIG'
- _inc_fontconfig=`pkg-config --cflags fontconfig`
- _ld_fontconfig=`pkg-config --libs fontconfig`
else
_def_fontconfig='#undef HAVE_FONTCONFIG'
fi
@@ -5422,7 +5360,7 @@
fi
if test "$_libdts" = yes ; then
_def_libdts='#define CONFIG_DTS 1'
- _ld_libdts="$_ld_libdts -ldts $_ld_lm"
+ _ld_libdts="$_ld_libdts -ldts"
_codecmodules="libdts $_codecmodules"
else
_def_libdts='#undef CONFIG_DTS'
@@ -5482,22 +5420,17 @@
#include <faac.h>
int main(void) { unsigned long x, y; faacEncOpen(48000, 2, &x, &y); return 0; }
EOF
- if ( cc_check -c -O4 -lfaac $_ld_lm ); then
- _faac=yes
- elif ( cc_check -c -O4 -lfaac -lmp4v2 -lstdc++ $_ld_lm ); then
- _faac=yes
- _ld_faac="-lmp4v2 -lstdc++"
- else
- _faac=no
- fi
+ _faac=no
+ for _ld_tmp in "-lfaac" "-lfaac -lmp4v2 -lstdc++" ; do
+ cc_check -c -O4 $_ld_tmp $_ld_lm && _ld_faac="$_ld_tmp" && faac=yes && break
+ done
fi
if test "$_faac" = yes ; then
_def_faac="#define HAVE_FAAC 1"
- _codecmodules="$_codecmodules faac"
- _ld_faac="-lfaac $_ld_faac"
+ _codecmodules="faac $_codecmodules"
else
_def_faac="#undef HAVE_FAAC"
- _nocodecmodules="$_nocodecmodules faac"
+ _nocodecmodules="faac $_nocodecmodules"
fi
echores "$_faac"
@@ -5513,7 +5446,10 @@
fi
# internal faad: check if our dear gcc is able to compile it...
cp "`pwd`/libfaad2/cfft.c" $TMPC
- if ( cc_check -c -O4 $_march $_mcpu $_pipe -ffast-math -fomit-frame-pointer -D_GNU_SOURCE $_inc_faad ); then
+ if test "$_lrintf" = yes ; then
+ _faad_extra=-DHAVE_LRINTF
+ fi
+ if ( cc_check -c -O4 $_march $_mcpu $_pipe -ffast-math -fomit-frame-pointer -D_GNU_SOURCE $_inc_faad $_faad_extra); then
_faad_internal=yes
else
_faad_internal="no (broken gcc)"
@@ -5786,26 +5722,16 @@
int main(void) {}
EOF
- _live_dist=no
- if test -z "$_livelibdir" ; then
+ _live=no
+ for I in "$_livelibdir" "$_libdir/live" "/usr/lib/live" "/usr/local/live" "/usr/local/lib/live" ; do
+ cc_check -I$I/liveMedia/include -I$I/UsageEnvironment/include -I$I/groupsock/include && _livelibdir=$I && _live=yes && break
+ done
+ if test "$_live" != yes ; then
if cc_check -I/usr/include/liveMedia -I/usr/include/UsageEnvironment -I/usr/include/groupsock; then
_live_dist=yes
- else
- for I in $_libdir/live /usr/lib/live /usr/local/live /usr/local/lib/live; do
- if test -d "$I" ; then
- _livelibdir="$I"
- break;
- fi;
- done
fi
fi
- if test "$_live_dist" = no && test "$_livelibdir" && cc_check -I$_livelibdir/liveMedia/include \
- -I$_livelibdir/UsageEnvironment/include -I$_livelibdir/groupsock/include; then
- _live=yes
- else
- _live=no
- fi
TMPC=$_TMPC
fi
if test "$_live" = yes && test "$_network" = yes ; then
@@ -6107,7 +6033,7 @@
#include <xvid.h>
int main(void) { xvid_init(0, 0, 0, 0); return 0; }
EOF
-_ld_xvid="$_ld_xvid -lxvidcore $_ld_lm"
+_ld_xvid="$_ld_xvid -lxvidcore"
if test "$_xvid" != no && cc_check $_inc_xvid $_ld_xvid ; then
_xvid=yes
_def_xvid3='#define HAVE_XVID3 1'
@@ -6155,7 +6081,7 @@
#endif
int main(void) { x264_encoder_open((void*)0); return 0; }
EOF
-_ld_x264="$_ld_x264 -lx264 $_ld_lm $_ld_pthread"
+_ld_x264="$_ld_x264 -lx264 $_ld_pthread"
if test "$_x264" != no && \
( cc_check $_inc_x264 $_ld_x264 || \
( test "$_x11" = yes && cc_check $_inc_x264 $_inc_x11 $_ld_x264 $_ld_x11 )) ; \
More information about the MPlayer-dev-eng
mailing list