[MPlayer-dev-eng] [PATCH] suboption escaping

[Reimar Döffinger]

Hi,
On Tue, Aug 16, 2005 at 11:59:26PM -0500, Joey Parrish wrote:
> On Tue, Aug 16, 2005 at 11:05:11AM +0200, Reimar Döffinger wrote:
> > I'd really like not to have yet another way of escaping. But if you
> > think it really, absolutely is necessary, at least document it!
> 
> Well, it's not yet another.  The reason for this patch is because there
> is NO SUCH METHOD in the option parser.  The subopt helper has the %len%
> method, but that does not help.  If I am mistaken, please correct me.

I think it is yet another, because it does not work exactly like any of
the other methods, e.g. it doesn't support escaping via "" (like the
normal option parser), and also it won't work (from what I can tell) for
specifying an option ending in \ (important for e.g. windows) - unless
you make it the last option and add two \.
I also think that your patch makes it impossible to specify an option
value that contains a '='?
I am also unhappy about the fact that so many place must be changed, but
that probably isn't your patches fault :-(.
I'd like this to be fixed, but IMHO this way is even more a hack than my
%len% method is (and I am still not entirely happy about that one, it is
only really useful for GUIs).

> And I would, from a Unix point of view, naturally expect MPlayer to
> allow escaping using a backslash.  So where should I document this?

I don't know, I put it in the general usage section of the man page.

Greetings,
Reimar Döffinger