[MPlayer-dev-eng] GTK2

[Alexander Strasser]

Hi,

Onur Kucuk wrote:
> > Look for gtk2 and use it if available, otherwise fall back to gtk1. At
> > least IMHO.
> 
>  Ok here is a tidied up one. Tried to follow the style, though I
> still believe that part (in configure, checking gtk stuff) should be
> indented by one step as they are all in "if ($_gui = yes)"
[...]
> +  if ( pkg-config gtk+-2.0 --modversion ) &> /dev/null ; then
[...]
> +    if ( pkg-config glib-2.0 --modversion ) &> /dev/null ; then

  Why do you use a subshell here and is &> really portable? AFAIK not.
Maybe I am just to tired but i think would rather like to see it done
this way:
  if pkg-config gtk+-2.0 --modversion >/dev/null 2>&1 ; then

  Didn't look at the remaining patch.

[...]

  Alex (beastd)