[MPlayer-dev-eng] GTK2

[Guillaume POIRIER]

Hi,

On 8/14/05, Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de> wrote:
> Hi,
> On Sun, Aug 14, 2005 at 10:34:17AM +0200, Reimar D?ffinger wrote:
> > On Sun, Aug 14, 2005 at 04:37:17AM +0300, Onur Kucuk wrote:
> > >  Here is a patch to make MPlayer gui GTK2. Besides benefits of GTK2
> > > (Unicode) it should provide more stability while using the arts
> > > audio output with gui.
> >
> > I ran across that patch a few days ago but didn't get to cleaning it up.
> > So now you can do that :-)
> > Comments on the patch:
> > First of all you have a lot of whitespace changes, which makes the patch
> > very hard to read - especially which part of configure you changed and
> > which ones are unchanged is very difficult to see.
> 
> And they were the reason why nobody noticed the missing = sign in the
> configure part...
> I attached a cleaned-up version. Though the configure part and the while
> loop might still be worth a closer look.

Works quite nice here (AMD64 Ubuntu Breezy). Would that patch allow
MPlayer to have its GUI working on Windows too?

Guillaume
-- 
A legend is an old man with a cane known for
what he used to do. I'm still doing it.
  -- Miles Davis