[MPlayer-dev-eng] Re: [PATCH] allow multiple help clauses on the command line

Alban Bedel albeu at free.fr
Thu Aug 11 11:54:14 CEST 2005


On Wed, 10 Aug 2005 20:38:49 -0400
kiriuja <mplayer-patches at en-directo.net> wrote:

> Updated patch.
> 
> - Account for the new demuxer_help.
> - Remove M_OPT_EXIT.
> - Use global int opt_exit instead.

I don't like that patch very much. In particular the opt_exit global thing
in m_config.c is quiet ugly. imho you shouldn't remove the M_OPT_EXIT
return code, instead modify the commande line parsers (parser-m?cmp.c) so
that they don't exit on M_OPT_EXIT but pass it up properly the caller.
So *not* with a global, modify the arguments to the command line parser
if you need to.

	Albeu

	




More information about the MPlayer-dev-eng mailing list